Skip to content

[FEATURE] add tabs layout for dashboards#135

Draft
jgbernalp wants to merge 1 commit into
mainfrom
feat/add-tab-layout
Draft

[FEATURE] add tabs layout for dashboards#135
jgbernalp wants to merge 1 commit into
mainfrom
feat/add-tab-layout

Conversation

@jgbernalp

Copy link
Copy Markdown
Contributor

Description

This PR adds support for tab layouts to dashboards, the current grid layout is left unchanged and the tabs support is additive. Tabs internally use the same grid system.

Part 2 of: perses/perses#4067
needs:

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp requested a review from a team as a code owner May 14, 2026 18:03
@jgbernalp jgbernalp requested review from ibakshay and shahrokni May 14, 2026 18:49
@sradco

sradco commented May 25, 2026

Copy link
Copy Markdown

Hi @jgbernalp, any update on this?

@Nexucis

Nexucis commented May 26, 2026

Copy link
Copy Markdown
Member

I think Gabriel is off for a couple of days @sradco.

In the meantime, @Gladorme and / or @shahrokni can you review the PR please ?

@jgbernalp jgbernalp marked this pull request as draft June 8, 2026 06:58
@jgbernalp

Copy link
Copy Markdown
Contributor Author

@sradco @Nexucis I marked it as draft as this needs a bit rework to define if the tabs are part of a group or not.

@sradco

sradco commented Jun 8, 2026

Copy link
Copy Markdown

@sradco @Nexucis I marked it as draft as this needs a bit rework to define if the tabs are part of a group or not.

@jgbernalp Thanks for the update.
I think the question you're working through ("are tabs part of a group or not") aligns with what I asked on perses/perses#4068 - I think we want tabs as a top-level layout concept rather than nested inside a collapsible group. The tab bar itself would replace the group header, with each tab page still supporting collapsible grid sections internally.

Happy to help clarify the requirements or test once you have a direction. No rush.

@sradco

sradco commented Jun 18, 2026

Copy link
Copy Markdown

Hi, Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants