fix encoding errors when paths contain non-ascii characters #225#298
Draft
ninmonkey wants to merge 1 commit intopester:mainfrom
Draft
fix encoding errors when paths contain non-ascii characters #225#298ninmonkey wants to merge 1 commit intopester:mainfrom
ninmonkey wants to merge 1 commit intopester:mainfrom
Conversation
…ester#225 ) Explicitly set `utf8` to ensure `PesterInterface.ps1` is using utf8 encoding for json filepaths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error was writing json filepaths like
foo.🐒asfoo.≡ƒÉÆcausing the missing path errors.Making this explicit means
PesterInterface.ps1will write json paths usingutf8even when ran frompwsh -NoProfileTo reproduce the error
You should start a new terminal. Running
pwsh -Nopalone is not sufficient. ( ie: it doesn't always reproduce after encoding is set once )