Feat: Ability to Grab Issues from Other GitHub Repos#4
Open
omgitsbillryan wants to merge 14 commits intopeter-murray:mainfrom
Open
Feat: Ability to Grab Issues from Other GitHub Repos#4omgitsbillryan wants to merge 14 commits intopeter-murray:mainfrom
omgitsbillryan wants to merge 14 commits intopeter-murray:mainfrom
Conversation
Feat/target gh repository
Author
|
@peter-murray what do you think? |
peter-murray
requested changes
Jan 20, 2022
Owner
peter-murray
left a comment
peter-murray
left a comment
There was a problem hiding this comment.
Thank you for this, I have only one suggestion around the validation on the input from a user and prefer to fail early with a nicer error to the user if they make a mistake in passing in a repository (i.e. not in the full name form).
|
|
||
| getIssueBody(id) { | ||
| getIssueBody(id, repository) { | ||
| const [owner, repo] = repository.split('/'); |
Owner
There was a problem hiding this comment.
My only issue here is that it is possible for a user to provide an input that is not in this form and we would not detect this of fail nicely with the following call.
I would suggest that we validate the repository input early in the execution when we obtain that value from the user inputs and pass a consistent {owner: '', repo: ''} object to this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
repositoryparam to allow the user to specify the repository where the GitHub issue is located. Allows for fetching issues from repos other than where the workflow was executed from.