[codex] Use HF token file for app auth#43
Closed
peteromallet wants to merge 1 commit intomainfrom
Closed
Conversation
Owner
Author
|
Pushed the auth change directly to main in acc76fb, closing this draft PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.cache/huggingface/tokenas the sole Hugging Face auth source.HF_TOKENinto sidecar runs so app auth state matches sidecar behavior.scripts/build-sidecar.shso the smoke test respects the configuredPYTHONbinary.Why
The previous app auth path wrote both macOS Keychain and the Hugging Face token file. If the token file disappeared and Keychain access failed, the UI could report the token as missing even though the user had pasted and used it before. File-only auth matches Hugging Face CLI behavior and avoids Keychain permission/signing edge cases.
Validation
TAURI_CONFIG='{"bundle":{"externalBin":[]}}' cargo test -q -p dataclaw-appPYENV_VERSION=3.11.11 python -m pytest tests/test_config.py tests/test_cli_common.py -qpnpm -C app buildPYTHON=/tmp/dataclaw-sidecar-venv/bin/python make build-sidecarmake release-localNotes
The rebuilt local app was launched from
app/src-tauri/target/release/bundle/macos/DataClaw.app.