Skip to content

docs(initiatives): record review-ready gate now deployed & verified live (#736)#953

Merged
don-petry merged 4 commits into
mainfrom
docs/mq-gate-now-deployed
Jun 27, 2026
Merged

docs(initiatives): record review-ready gate now deployed & verified live (#736)#953
don-petry merged 4 commits into
mainfrom
docs/mq-gate-now-deployed

Conversation

@don-petry

@don-petry don-petry commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

What

Adds a dated 2026-06-26 update note to docs/initiatives/auto-rebase-vs-merge-queue.md (§2) plus a Status-line tag, recording that the review-ready auto-rebase gate is now actually deployed org-wide and verified live.

Why

The §2 "≥50% MET" verdict was computed from the eligible-PR multiplier (a predicate snapshot). At the time this record was written, the restriction was not yet filtering anything in production: the central reusable defaulted tooling_ref to v1, which predates lib/eligibility.sh (added in #468), so every auto-rebase run failed to source the predicate — petry-projects/.github's own runs errored, and consumer repos still ran the original unrestricted fan-out.

That latent regression was fixed in petry-projects/.github#528 (2026-06-24, sources the predicate from github.job_workflow_sha), after which the auto-rebase/stable channel was promoted org-wide. Now verified live — e.g. .github-private PR #744 (no approval, no auto-rebase:ready label) went from auto-updated-every-push to skipped.

Decision impact

None to the call — Merge Queue stays deferred (§4). But the free mitigation that justified deferring is now genuinely in effect, so the deferral holds on stronger footing. Docs-only.

Relates to epic #736.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated the initiative status to reflect that the free mitigation is now validated, deployed across the organization, and verified live.
    • Clarified that a previously reported metric was based on an eligibility snapshot, and added a note about a rollout issue that was corrected.
    • Kept the Merge Queue decision as an open, human-deferred question.

The §2 ≥50% verdict was computed from the eligible-PR multiplier (a predicate
snapshot). At authoring time the restriction was not actually filtering in
production: the central reusable defaulted tooling_ref to v1 (predates
eligibility.sh from #468), so auto-rebase failed to source the predicate and
ran the original unrestricted fan-out everywhere. Fixed in
petry-projects/.github#528 (job_workflow_sha) on 2026-06-24, then the
auto-rebase/stable channel was promoted org-wide. Gate now verified live
(.github-private PR#744 went from auto-updated to skipped).

Adds a dated §2 update note + Status-line tag. The free mitigation behind the
"defer Merge Queue" decision is now genuinely in effect, so the §4 deferral
holds on stronger footing. Docs-only; no decision change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019LUUSUQHqwLWZ583SAs41K
@don-petry don-petry requested a review from a team as a code owner June 26, 2026 23:18
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5777f8a9-13bf-494c-8516-5621d2616a75

📥 Commits

Reviewing files that changed from the base of the PR and between 96ad1d9 and f65cb11.

📒 Files selected for processing (1)
  • docs/initiatives/auto-rebase-vs-merge-queue.md

📝 Walkthrough

Walkthrough

The initiative document updates its status to reflect org-wide deployment and live verification, and adds a production update explaining the earlier metric snapshot, a predicate sourcing issue, the remediation, and the observed post-fix behavior.

Changes

Initiative status and rollout update

Layer / File(s) Summary
Status and rollout note
docs/initiatives/auto-rebase-vs-merge-queue.md
The status line now says the free mitigation is deployed org-wide and verified live on 2026-06-26, and the update section adds the predicate snapshot note, rollout issue, fix reference, promotion to auto-rebase/stable, and live example.

Possibly related PRs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the docs-only update recording that the review-ready gate is deployed and verified live.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/mq-gate-now-deployed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Auto-rebase Fan-out Reduction decision record to document that the mitigation gate has been successfully deployed org-wide and verified live in production. It includes details about a resolved latent regression involving the tooling_ref default. The reviewer suggested a minor formatting improvement to wrap a repository reference in backticks for consistency, which is a valid and helpful suggestion.

Comment thread docs/initiatives/auto-rebase-vs-merge-queue.md Outdated
@don-petry don-petry enabled auto-merge (squash) June 26, 2026 23:20
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-27T00:20:27Z.

@don-petry don-petry disabled auto-merge June 26, 2026 23:20
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 26, 2026
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry don-petry enabled auto-merge (squash) June 26, 2026 23:22
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-27T00:22:56Z.

@don-petry don-petry disabled auto-merge June 27, 2026 00:22
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #953
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-27T00:54:03Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-27T00:54:03Z

@don-petry don-petry enabled auto-merge (squash) June 27, 2026 00:24
@sonarqubecloud

Copy link
Copy Markdown

@don-petry don-petry disabled auto-merge June 27, 2026 00:25
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry don-petry enabled auto-merge (squash) June 27, 2026 00:26
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-06-27T01:26:27Z.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: f48671a753ba9485a55d3f6925e88708a7109188
Review mode: triage-approved (single reviewer)

Summary

Docs-only change (+14/-1) to docs/initiatives/auto-rebase-vs-merge-queue.md: adds a dated 2026-06-26 update note and a Status-line tag recording that the review-ready auto-rebase gate is now deployed org-wide and verified live. No code, config, or workflow changes.

Linked issue analysis

No linked closing issues. PR relates to epic #736 (Merge Queue go/no-go), which remains intentionally deferred to a human; this PR only records production status and explicitly states the decision call is unchanged. Nothing to substantively address.

Findings

No blocking findings. Single markdown file touched; no auth/secrets/migrations/CI-security surface. gemini-code-assist left one non-blocking nit (wrap a repo reference in backticks for consistency); CodeRabbit reported no actionable comments and approved at the head commit. No unresolved blocking review threads or unanswered human questions.

CI status

All required checks green — Lint, ShellCheck, CodeQL (actions+python), SonarCloud, Secret scan (gitleaks), AgentShield, Agent Security Scan, unit-tests, guard, holdout-guard, review all SUCCESS; dependency-audit ecosystem jobs and dependabot SKIPPED (expected for a docs-only change). No failures.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry don-petry merged commit 19e5235 into main Jun 27, 2026
25 checks passed
@don-petry don-petry deleted the docs/mq-gate-now-deployed branch June 27, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants