Skip to content

ci: inline NOSONAR(S7637) marker on dev-lead caller stub (#549 canonical migration)#557

Open
don-petry wants to merge 3 commits into
mainfrom
chore/s7637-inline-marker
Open

ci: inline NOSONAR(S7637) marker on dev-lead caller stub (#549 canonical migration)#557
don-petry wants to merge 3 commits into
mainfrom
chore/s7637-inline-marker

Conversation

@don-petry

@don-petry don-petry commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Adds the canonical inline # NOSONAR(githubactions:S7637) marker to the channel-pinned first-party dev-lead caller stub (Option A, #549/#551). Preserves the @dev-lead/ring0 channel pin. Part of the controlled fleet migration to inline markers (not the weekly audit). hands-off so no agent re-SHA-pins the channel ref. Legacy per-file sonar-project.properties S7637 entries removed in a verified follow-up.

Summary by CodeRabbit

  • Chores
    • Updated an automation workflow comment and permissions note to keep CI configuration aligned and maintain status access for the related job.

@don-petry don-petry requested a review from a team as a code owner June 28, 2026 11:05
@don-petry don-petry added the dev-lead:hands-off Exclude this PR/issue from the dev-lead agent label Jun 28, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: aa9460c3-d0db-4346-bda9-2e4deca366e0

📥 Commits

Reviewing files that changed from the base of the PR and between 55d48fd and e001e04.

📒 Files selected for processing (1)
  • .github/workflows/dev-lead.yml

📝 Walkthrough

Walkthrough

In .github/workflows/dev-lead.yml, a # NOSONAR(githubactions:S7637) first-party channel ref inline comment is added to the reusable workflow uses: line, and the statuses: read permissions entry retains its existing comment.

Changes

Dev-lead workflow NOSONAR annotation

Layer / File(s) Summary
Inline NOSONAR suppression
.github/workflows/dev-lead.yml
Adds # NOSONAR(githubactions:S7637) first-party channel ref trailing comment to the uses: line; statuses: read permission comment is preserved unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • petry-projects/.github#551: Introduces the inline # NOSONAR(githubactions:S7637) first-party channel ref marker pattern and the audit logic that checks for it, which this PR applies to dev-lead.yml.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the workflow change and accurately describes the inline NOSONAR marker migration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/s7637-inline-marker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-lead:hands-off Exclude this PR/issue from the dev-lead agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant