feat: implement issue #350 — Compliance: sonar-s7637-exemption-missing#353
feat: implement issue #350 — Compliance: sonar-s7637-exemption-missing#353don-petry wants to merge 2 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Code Review
This pull request adds SonarCloud S7637 exemptions for several first-party reusable GitHub Actions workflow files in sonar-project.properties. However, the reviewer pointed out that the entire .github/ directory is currently excluded from SonarCloud analysis in the sonar.exclusions setting, making these new ignore rules redundant. It is recommended to update sonar.exclusions to allow scanning of these workflows so that the exemptions can actually take effect.
| # file individually; ci.yml / sonarcloud.yml and any third-party `uses:` keep | ||
| # full SHA-pin enforcement — do NOT replace these with a blanket | ||
| # `workflows/*.yml` resourceKey. | ||
| sonar.issue.ignore.multicriteria=s7637_agentshield,s7637_prreviewmention,s7637_prautoreview,s7637_autorebase,s7637_dependabotrebase,s7637_dependabotautomerge,s7637_dependencyaudit,s7637_featureideation,s7637_addtoproject,s7637_devlead |
There was a problem hiding this comment.
The multicriteria ignore rules configured here target GitHub Actions workflow files (e.g., **/agent-shield.yml). However, line 5 of this file currently excludes the entire .github/ directory from SonarCloud analysis:
sonar.exclusions=_bmad/**,_bmad-output/**,.claude/**,.github/**
Because of this exclusion, SonarCloud will not scan any files under .github/workflows/, making these githubactions:S7637 ignore rules completely redundant and ineffective.
To resolve this and allow SonarCloud to analyze your workflows (while still applying these exemptions), you should update sonar.exclusions to not exclude .github/** (or at least exclude everything in .github except .github/workflows/**). For example:
sonar.exclusions=_bmad/**,_bmad-output/**,.claude/**
There was a problem hiding this comment.
Fixed in sonar-project.properties line 5: removed .github/** from sonar.exclusions. SonarCloud will now scan .github/workflows/, which means all ten githubactions:S7637 multicriteria ignore rules added in this PR will actually take effect for their respective stub files.
|
Warning Review limit reached
More reviews will be available in 58 minutes and 35 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dev-Lead — review-changes (applied)Changes committed and pushed. |
|
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
Closing per fleet compliance-PR cleanup; will regenerate when fixes are ready. |
Pull request was closed



Closes #350
Implemented by dev-lead agent. Please review.