Skip to content

feat: implement issue #350 — Compliance: sonar-s7637-exemption-missing#353

Closed
don-petry wants to merge 2 commits into
mainfrom
dev-lead/issue-350-20260626-1436
Closed

feat: implement issue #350 — Compliance: sonar-s7637-exemption-missing#353
don-petry wants to merge 2 commits into
mainfrom
dev-lead/issue-350-20260626-1436

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Closes #350

Implemented by dev-lead agent. Please review.

@don-petry
don-petry requested a review from a team as a code owner June 26, 2026 14:38
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds SonarCloud S7637 exemptions for several first-party reusable GitHub Actions workflow files in sonar-project.properties. However, the reviewer pointed out that the entire .github/ directory is currently excluded from SonarCloud analysis in the sonar.exclusions setting, making these new ignore rules redundant. It is recommended to update sonar.exclusions to allow scanning of these workflows so that the exemptions can actually take effect.

Comment thread sonar-project.properties
# file individually; ci.yml / sonarcloud.yml and any third-party `uses:` keep
# full SHA-pin enforcement — do NOT replace these with a blanket
# `workflows/*.yml` resourceKey.
sonar.issue.ignore.multicriteria=s7637_agentshield,s7637_prreviewmention,s7637_prautoreview,s7637_autorebase,s7637_dependabotrebase,s7637_dependabotautomerge,s7637_dependencyaudit,s7637_featureideation,s7637_addtoproject,s7637_devlead

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The multicriteria ignore rules configured here target GitHub Actions workflow files (e.g., **/agent-shield.yml). However, line 5 of this file currently excludes the entire .github/ directory from SonarCloud analysis:

sonar.exclusions=_bmad/**,_bmad-output/**,.claude/**,.github/**

Because of this exclusion, SonarCloud will not scan any files under .github/workflows/, making these githubactions:S7637 ignore rules completely redundant and ineffective.

To resolve this and allow SonarCloud to analyze your workflows (while still applying these exemptions), you should update sonar.exclusions to not exclude .github/** (or at least exclude everything in .github except .github/workflows/**). For example:

sonar.exclusions=_bmad/**,_bmad-output/**,.claude/**

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in sonar-project.properties line 5: removed .github/** from sonar.exclusions. SonarCloud will now scan .github/workflows/, which means all ten githubactions:S7637 multicriteria ignore rules added in this PR will actually take effect for their respective stub files.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 35 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b506f9a5-6387-406c-bfe7-6f39f49b83da

📥 Commits

Reviewing files that changed from the base of the PR and between 358f6f1 and be38efa.

📒 Files selected for processing (1)
  • sonar-project.properties
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-350-20260626-1436

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 26, 2026 14:39
@don-petry
don-petry disabled auto-merge June 26, 2026 14:40
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry enabled auto-merge (squash) June 26, 2026 14:42
@don-petry
don-petry disabled auto-merge June 26, 2026 14:42
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0 (Quality Gate passed)
- No actionable issues identified; SonarCloud analysis passed with 0 new issues
- PR correctly removes .github exclusion to enable scanning + adds targeted S7637 exemptions
Files changed: sonar-project.properties
Skipped (informational): 0
```
**Conclusion:** No fixes needed. The PR is ready—all automated quality gates have passed, and the changes correctly implement the intended SonarCloud configuration.

@don-petry

Copy link
Copy Markdown
Contributor Author

Closing per fleet compliance-PR cleanup; will regenerate when fixes are ready.

@don-petry don-petry closed this Jul 2, 2026
auto-merge was automatically disabled July 2, 2026 14:19

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: sonar-s7637-exemption-missing

2 participants