-
Notifications
You must be signed in to change notification settings - Fork 8
Create BeagleBoneSWD.py #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BeagleBone gpio integration
|
Thanks for this pull request. There's one problem though - it's licensing doesn't match main codebase licensing (your code GPLv3, main codebase BSD). I personally value GPL and think that it should be the license for the toolsets, but at the same time, I value original author(s)' selection of license and think it's a good courtesy to them to not change it on a whim. That's my thoughts about it, I'm open to other opinions/arguments. |
|
Sure no problem to move it to bsd, i do not care when adfing the header. I'll change it to bsd.
|
… base on AdaFruit GPIO lib for better readability
|
License back to BSD, I'm not yet really familiar with pull reqest. Hope it works like this. Tell me if it is ok. |
|
Thanks for coming back to this! Indeed, there were some tricky changes in these latest commits - like inconsistent tab vs spaces. I took freedom to run them thru "expand" command. I also put back your explicit copyright (c) - that's surely ok, as you're the author of that code. I also renamed both files to give a better hint how they different from each other. I also squashed all these changes to a single commit which is here: e942fb0 . Let me know if it's ok by you. Note that no code changes were done - only whitespace and "metadata". |
|
Sounds perfect to me ;)
|
|
I just add the RaspberryPi integration, It works really faster than BeagleBone and should be more frequent. If you can merge it would be perfect:) |
BeagleBone gpio integration