Skip to content

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Nov 21, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

⚠️ No Changeset found

Latest commit: 0d19aaa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

jumski commented Nov 21, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge:queue - adds this PR to the back of the merge queue
  • hotfix:queue - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nx-cloud
Copy link

nx-cloud bot commented Nov 21, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 0d19aaa

Command Status Duration Result
nx affected -t lint typecheck test --parallel -... ❌ Failed 3m 57s View ↗
nx affected -t test:e2e --parallel --base=origi... ✅ Succeeded 6m 39s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-23 00:30:16 UTC

@graphite-app graphite-app bot force-pushed the 11-21-introduce_prepush_git_hook branch 2 times, most recently from 7f2a5be to 9815af4 Compare November 21, 2025 11:58
@graphite-app graphite-app bot force-pushed the 11-21-sort_out_supabase_start_issues branch from 09e4d22 to 8c1c617 Compare November 21, 2025 11:59
@chatgpt-codex-connector
Copy link

💡 Codex Review

while [ $waited -lt $max_wait ]; do
local running_containers=$(docker ps --filter "name=supabase.*${project_id}" --format "{{.Names}}" 2>/dev/null)
if [ -z "$running_containers" ]; then

P1 Badge Container wait uses non-matching docker name filter

The new wait/cleanup logic never sees running Supabase containers because docker ps --filter "name=supabase.*${project_id}" is treated by Docker as a literal substring match, not a regex, so the .* characters must appear in the container name. Supabase containers are named without a literal *, so wait_for_containers_to_stop and force_cleanup_containers will always think nothing is running and skip the waiting/kill logic. If supabase stop leaves containers alive (the CLI bug this change tries to address), the script proceeds while those containers are still present, leading to start failures from name/port conflicts rather than the intended graceful cleanup.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@graphite-app graphite-app bot changed the base branch from 11-21-introduce_prepush_git_hook to graphite-base/409 November 21, 2025 12:29
@graphite-app graphite-app bot force-pushed the 11-21-sort_out_supabase_start_issues branch from 8c1c617 to 5987712 Compare November 21, 2025 12:30
@graphite-app graphite-app bot changed the base branch from graphite-base/409 to main November 21, 2025 12:30
@graphite-app graphite-app bot force-pushed the 11-21-sort_out_supabase_start_issues branch from 5987712 to a67830b Compare November 21, 2025 12:30
@jumski jumski force-pushed the 11-21-sort_out_supabase_start_issues branch 2 times, most recently from 3145003 to cb35276 Compare November 21, 2025 16:35
@jumski jumski force-pushed the 11-21-sort_out_supabase_start_issues branch from cb35276 to fc355c8 Compare November 21, 2025 20:54
@jumski jumski force-pushed the 11-21-sort_out_supabase_start_issues branch 2 times, most recently from e455b62 to a8ea560 Compare November 21, 2025 21:23
@github-actions
Copy link
Contributor

🔍 Preview Deployment: Website

Deployment successful!

🔗 Preview URL: https://pr-409.pgflow.pages.dev

📝 Details:

  • Branch: 11-21-sort_out_supabase_start_issues
  • Commit: 1328b97122198cd9bdf2b7b1d0f8e5a8993fbf1d
  • View Logs

_Last updated: _

@jumski jumski force-pushed the 11-21-sort_out_supabase_start_issues branch from a8ea560 to 0d19aaa Compare November 23, 2025 00:21
Comment on lines +125 to +134
# Detect netcat version and use appropriate syntax
# DO NOT pass address after port - that makes nc act as client!
if nc -h 2>&1 | grep -q "OpenBSD"; then
# OpenBSD netcat (common on Ubuntu/Debian)
nc -l "$port" </dev/null >/dev/null 2>&1 &
else
# GNU netcat (traditional)
nc -l -p "$port" </dev/null >/dev/null 2>&1 &
fi
NC_PID=$!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The netcat version detection and port binding might be unreliable in CI environments. Improve by adding better error handling, trying alternative syntaxes if the first attempt fails, and verifying the port is actually bound by checking with another netcat instance.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +137 to +138
sleep 0.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 0.1 second sleep might not be enough time for netcat to bind to the port in busy CI environments. Increase this to at least 1 second to ensure the port binding has time to complete or fail.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants