-
Notifications
You must be signed in to change notification settings - Fork 15
sort out supabase start issues #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected -t lint typecheck test --parallel -... |
❌ Failed | 3m 57s | View ↗ |
nx affected -t test:e2e --parallel --base=origi... |
✅ Succeeded | 6m 39s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-23 00:30:16 UTC
7f2a5be to
9815af4
Compare
09e4d22 to
8c1c617
Compare
💡 Codex Reviewpgflow/scripts/supabase-start.sh Lines 68 to 70 in 09e4d22
The new wait/cleanup logic never sees running Supabase containers because ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
9815af4 to
a0cb075
Compare
8c1c617 to
5987712
Compare
5987712 to
a67830b
Compare
3145003 to
cb35276
Compare
cb35276 to
fc355c8
Compare
e455b62 to
a8ea560
Compare
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-409.pgflow.pages.dev 📝 Details:
_Last updated: _ |
a8ea560 to
0d19aaa
Compare
| # Detect netcat version and use appropriate syntax | ||
| # DO NOT pass address after port - that makes nc act as client! | ||
| if nc -h 2>&1 | grep -q "OpenBSD"; then | ||
| # OpenBSD netcat (common on Ubuntu/Debian) | ||
| nc -l "$port" </dev/null >/dev/null 2>&1 & | ||
| else | ||
| # GNU netcat (traditional) | ||
| nc -l -p "$port" </dev/null >/dev/null 2>&1 & | ||
| fi | ||
| NC_PID=$! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The netcat version detection and port binding might be unreliable in CI environments. Improve by adding better error handling, trying alternative syntaxes if the first attempt fails, and verifying the port is actually bound by checking with another netcat instance.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| sleep 0.1 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 0.1 second sleep might not be enough time for netcat to bind to the port in busy CI environments. Increase this to at least 1 second to ensure the port binding has time to complete or fail.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.

No description provided.