Skip to content

ci: remove e2e:install dependency and improve JSR authentication handling #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jumski wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: remove e2e:install dependency and improve JSR authentication handling #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/cli/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"test": {
"executor": "nx:noop",
"inputs": ["default", "^production"],
"dependsOn": ["test:vitest", "e2e:install"],
"dependsOn": ["test:vitest"],
"options": {
"parallel": false
}
Expand Down
16 changes: 15 additions & 1 deletion scripts/snapshot-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,21 @@ if [[ -f pkgs/edge-worker/jsr.json ]]; then
JSR_PUBLISHED_VERSION=$(jq -r '.version' pkgs/edge-worker/jsr.json)
echo ""
echo -e "${BOLD}Publishing to JSR...${NC}"
if ( cd pkgs/edge-worker && pnpm jsr publish --allow-slow-types --allow-dirty ) ; then

# Check for JSR authentication (similar to how npm uses ~/.npmrc)
# JSR/Deno caches credentials in ~/.deno/credentials.json after `deno login`
if [[ -z "${JSR_TOKEN:-}" ]] && [[ ! -f "$HOME/.deno/credentials.json" ]]; then
echo -e "${YELLOW}⚠ No JSR credentials found${NC}"
echo ""
echo -e "To authenticate with JSR (one-time setup, like 'npm login'):"
echo -e " ${BLUE}deno login${NC}"
echo ""
echo -e "Or for CI/CD, set the JSR_TOKEN environment variable."
echo ""
echo -e "${YELLOW}Skipping JSR publish.${NC}"
JSR_SUCCESS=true # Don't fail the whole release
JSR_PUBLISHED_VERSION=""
elif ( cd pkgs/edge-worker && pnpm jsr publish --allow-slow-types --allow-dirty ) ; then
echo -e "${GREEN}✓ JSR package published${NC}"
else
echo -e "${RED}✗ JSR publish failed${NC}"
Expand Down