Skip to content

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Dec 23, 2025

Rename input parameters in step handlers for better clarity

This PR renames the input parameters in step handlers to improve clarity and better reflect their purpose:

  • Root steps (no dependencies) now use flowInput instead of input.run to directly access flow input
  • Dependent steps now use deps instead of input to access outputs from dependency steps
  • Context parameter is now consistently named ctx where used

These changes make the code more intuitive by:

  1. Clearly distinguishing between flow input and dependency outputs
  2. Using parameter names that better reflect their content
  3. Maintaining consistent naming conventions throughout the codebase

The changes affect example code in the documentation as well as actual implementation code, ensuring consistency across the entire project.

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

⚠️ No Changeset found

Latest commit: 6090a08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Dec 23, 2025

View your CI Pipeline Execution ↗ for commit 6090a08

Command Status Duration Result
nx run edge-worker:test:integration ✅ Succeeded 3m 57s View ↗
nx run client:e2e ✅ Succeeded 2m 52s View ↗
nx run cli:e2e ✅ Succeeded 7s View ↗
nx run edge-worker:e2e ✅ Succeeded 48s View ↗
nx affected -t verify-exports --base=origin/mai... ✅ Succeeded 3s View ↗
nx affected -t build --configuration=production... ✅ Succeeded 3s View ↗
nx affected -t lint typecheck test --parallel -... ✅ Succeeded 26s View ↗
nx run core:pgtap ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-23 15:34:04 UTC

@jumski jumski force-pushed the 12-23-migrate_48_files_from_input.run_to_asymmetric_handler_signatures branch from 1ed5f8d to 6090a08 Compare December 23, 2025 15:26
@github-actions
Copy link
Contributor

🔍 Preview Deployment: Website

Deployment successful!

🔗 Preview URL: https://pr-557.pgflow.pages.dev

📝 Details:

  • Branch: 12-23-migrate_48_files_from_input.run_to_asymmetric_handler_signatures
  • Commit: a3de0c03d478d1f04b880baf169eaabe7d149208
  • View Logs

_Last updated: _

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants