Dodanie kilku wyrazów bliskoznacznych. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phaux
requested changes
Sep 25, 2021
| let new_str = match ident_str.as_str() { | ||
| "Źle" => "Err", | ||
| "Dobrze" => "Ok", | ||
| "Dobrze" | "Prawilnie" => "Ok", |
Owner
There was a problem hiding this comment.
Myślę, że oprócz Prawilnie powinniśmy dodatkowo wspierać Wporzo oraz Elegancko:
Suggested change
| "Dobrze" | "Prawilnie" => "Ok", | |
| "Dobrze" | "Prawilnie" | "Wporzo" | "Elegancko" => "Ok", |
| "rób" => "do", | ||
| "prawda" => "true", | ||
| "enumeracja" => "enum", | ||
| "enumeracja" | "wyliczanie" | "wyliczanka" | "wyliczaj" => "enum", |
Owner
There was a problem hiding this comment.
Moim zdaniem wyliczaj tutaj nie pasuje, bo to czasownik, a reszta to rzeczowniki.
Suggested change
| "enumeracja" | "wyliczanie" | "wyliczanka" | "wyliczaj" => "enum", | |
| "enumeracja" | "wyliczanie" | "wyliczanka" => "enum", |
grzegorz-aleksander-klementowski
suggested changes
Dec 27, 2025
grzegorz-aleksander-klementowski
left a comment
grzegorz-aleksander-klementowski
left a comment
There was a problem hiding this comment.
Tak, enumeracja mi najbardziej mi się podoba. Jednakże za dużo dopasować do Ok() – myślę, że samo Dobrze wystarczy. Myślę, że dobre to będzie jak język będzie bardziej specyficzny, konkretny. Co do loop to myślę, że pętla też będzie dobre.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zapraszam do review.