This repository was archived by the owner on Aug 8, 2024. It is now read-only.
Add mini browser as install task#168
Draft
narendra-drupal wants to merge 2 commits intophenaproxima:mainfrom
Draft
Add mini browser as install task#168narendra-drupal wants to merge 2 commits intophenaproxima:mainfrom
narendra-drupal wants to merge 2 commits intophenaproxima:mainfrom
Conversation
narendra-drupal
commented
Aug 8, 2024
patches/project_browser/pb.patch
Outdated
Comment on lines
9
to
10
| - _permission: 'administer modules' | ||
| + _access: 'TRUE' |
Contributor
Author
There was a problem hiding this comment.
This was done, as admin user is not created till this step.
narendra-drupal
commented
Aug 8, 2024
Comment on lines
+106
to
+111
| - const url = Drupal.url( | ||
| - `drupal-org-proxy/project?${searchParams.toString()}`, | ||
| - ); | ||
| + const url = `${window.location.protocol}//${ | ||
| + window.location.host | ||
| + }/drupal-org-proxy/project?${searchParams.toString()}`; |
Contributor
Author
There was a problem hiding this comment.
This was done to avoid appending url to /core/install.php.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used https://www.drupal.org/project/project_browser/issues/3450629 to add mini browser as install step.