Conversation
Removed commas from "brew_array" between "8.2" and "8.3" versions. Added comment for Apache folder "apache_conf_path", if Apache is installed via Home Brew on Apple Silicon
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a syntax error in the brew_array definition and adds helpful comments for Apache configuration paths on Apple Silicon Macs.
- Fixed bash array syntax by removing commas between array elements "8.2", "8.3", and "8.4"
- Added documentation comments for alternative Apache configuration path when using Homebrew on Apple Silicon
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bkdotcom
reviewed
Nov 13, 2025
| fi | ||
|
|
||
| apache_change=1 | ||
| # Default Apache httpd folder |
There was a problem hiding this comment.
even better?:
apache_conf_path=""
apache_paths=(
"/opt/homebrew/etc/httpd/httpd.conf" # installed via Homebrew (new Apple Silicon)
"/usr/local/etc/httpd/httpd.conf" # installed via Homebrew (Intel) ?
"/etc/apache2/httpd.conf" # macOS default apache path
)
# Iterate over apache_paths to find first path that exists
for path in "${apache_paths[@]}"; do
apache_conf_path="$path"
if [[ -f "$path" ]]; then
break
fi
done
andrew-miller-rakuten
approved these changes
Nov 25, 2025
ikari7789
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed commas from "brew_array" between "8.2" and "8.3" versions.
Added comment for Apache folder "apache_conf_path", if Apache is installed via Home Brew on Apple Silicon