Draft
bazel/wee8: Run smoke tests in normal //... testing, remove bespoke CI job#1087
//... testing, remove bespoke CI job#1087Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
…... testing - Remove tags = ["manual"] from wee8_smoke_test and wee8_smoke_link_aarch64; target_compatible_with already gates by platform, manual was wrong here - Fix attribute ordering in bazel/v8/BUILD (srcs before copts) - Delete bespoke wee8-smoke CI job and remove from status needs; test job's bazel test //... picks up smoke test automatically - Fix wee8_smoke_test.cc: replace assert() with null checks, extend to Engine::make, drop <assert.h> - Fix wee8_prebuilt.bzl: replace hard fail() on missing sha256 with non-fatal incompatible BUILD, solving workspace-mode analysis and V8-bump deadlock; add procedure comment - Remove redundant repo_name = "abseil-cpp" from MODULE.bazel Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add wee8 smoke tests to normal bazel testing
bazel/wee8: Run smoke tests in normal Aug 13, 2026
//... testing, remove bespoke CI job
phlax
force-pushed
the
ci-wee8
branch
6 times, most recently
from
August 13, 2026 14:32
48ec132 to
a64992e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to envoyproxy#5050. Smoke tests were tagged
manual(excluding them frombazel test //...) and gated behind a standalonewee8-smokeCI job with no RBE, no--config=ci, and leftoverdebootstrap/qemu-user-staticinstalls — the opposite of the intended outcome. Additionally, missing-sha handling would hard-fail()at repo-setup time, breaking workspace-mode analysis and creating a V8-bump deadlock.Structural
tags = ["manual"]fromwee8_smoke_testandwee8_smoke_link_aarch64.target_compatible_withalready gates them by platform — incompatible targets are silently skipped in wildcard expansion, somanualwas redundant and harmful.wee8-smokeCI job and remove it fromstatusneeds. The existingtestjob (bazel test //... //sysroot:sysrootswith RBE +--config=ci, across bothworkspace/bzlmodmatrix legs) picks up//v8:wee8_smoke_testautomatically oncemanualis gone.Workspace-mode fix (
wee8_prebuilt.bzl)Replaced hard
fail()on missing sha256 with a non-fatal path that generates:This solves two problems:
@abseil-cpp/@icurepos (they'rebazel_dep-only); the real BUILD would fail to analyse. The incompatible stub lets//...skip gracefully.V8_VERSIONpreviously broke every build until shas were populated. Now only targets that explicitly depend on//v8:wee8fail, with a clear skip/incompatible signal rather than a repo-setup crash. A comment inwee8_prebuilt.bzldocuments the bump procedure.Other fixes
wee8_smoke_test.cc: replaceassert(config != nullptr)(elided under-c opt/NDEBUG) with unconditional null checks; extend toEngine::makefor a stronger link check; drop<assert.h>.MODULE.bazel: remove redundantrepo_name = "abseil-cpp"(already matches the module name).bazel/v8/BUILD: fix attribute ordering —srcsbeforecoptsper buildifier convention.