Skip to content

bazel/wee8: Run smoke tests in normal //... testing, remove bespoke CI job - #1087

Draft
phlax with Copilot wants to merge 3 commits into
ci-wee8from
copilot/ci-wee8
Draft

bazel/wee8: Run smoke tests in normal //... testing, remove bespoke CI job#1087
phlax with Copilot wants to merge 3 commits into
ci-wee8from
copilot/ci-wee8

Conversation

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown

Follow-up to envoyproxy#5050. Smoke tests were tagged manual (excluding them from bazel test //...) and gated behind a standalone wee8-smoke CI job with no RBE, no --config=ci, and leftover debootstrap/qemu-user-static installs — the opposite of the intended outcome. Additionally, missing-sha handling would hard-fail() at repo-setup time, breaking workspace-mode analysis and creating a V8-bump deadlock.

Structural

  • Remove tags = ["manual"] from wee8_smoke_test and wee8_smoke_link_aarch64. target_compatible_with already gates them by platform — incompatible targets are silently skipped in wildcard expansion, so manual was redundant and harmful.
  • Delete the wee8-smoke CI job and remove it from status needs. The existing test job (bazel test //... //sysroot:sysroots with RBE + --config=ci, across both workspace/bzlmod matrix legs) picks up //v8:wee8_smoke_test automatically once manual is gone.

Workspace-mode fix (wee8_prebuilt.bzl)

Replaced hard fail() on missing sha256 with a non-fatal path that generates:

cc_library(
    name = "wee8",
    target_compatible_with = ["@platforms//:incompatible"],
)

This solves two problems:

  1. Workspace-mode analysis: workspace mode has no @abseil-cpp/@icu repos (they're bazel_dep-only); the real BUILD would fail to analyse. The incompatible stub lets //... skip gracefully.
  2. V8-bump deadlock: bumping V8_VERSION previously broke every build until shas were populated. Now only targets that explicitly depend on //v8:wee8 fail, with a clear skip/incompatible signal rather than a repo-setup crash. A comment in wee8_prebuilt.bzl documents the bump procedure.

Other fixes

  • wee8_smoke_test.cc: replace assert(config != nullptr) (elided under -c opt/NDEBUG) with unconditional null checks; extend to Engine::make for a stronger link check; drop <assert.h>.
  • MODULE.bazel: remove redundant repo_name = "abseil-cpp" (already matches the module name).
  • bazel/v8/BUILD: fix attribute ordering — srcs before copts per buildifier convention.

…... testing

- Remove tags = ["manual"] from wee8_smoke_test and wee8_smoke_link_aarch64;
  target_compatible_with already gates by platform, manual was wrong here
- Fix attribute ordering in bazel/v8/BUILD (srcs before copts)
- Delete bespoke wee8-smoke CI job and remove from status needs;
  test job's bazel test //... picks up smoke test automatically
- Fix wee8_smoke_test.cc: replace assert() with null checks, extend to
  Engine::make, drop <assert.h>
- Fix wee8_prebuilt.bzl: replace hard fail() on missing sha256 with
  non-fatal incompatible BUILD, solving workspace-mode analysis and
  V8-bump deadlock; add procedure comment
- Remove redundant repo_name = "abseil-cpp" from MODULE.bazel

Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot AI changed the title [WIP] Add wee8 smoke tests to normal bazel testing bazel/wee8: Run smoke tests in normal //... testing, remove bespoke CI job Aug 13, 2026
Copilot AI requested a review from phlax August 13, 2026 12:14
@phlax
phlax force-pushed the ci-wee8 branch 6 times, most recently from 48ec132 to a64992e Compare August 13, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants