Draft
Conversation
HenrikEngen
force-pushed
the
feature/multitenant
branch
from
61d9f4c to
c7e2f78
Compare
…dded event_type_uuid to tables that should use this, added can_checkin column to ticket_type table
petterroea
reviewed
Aug 26, 2025
| op.create_foreign_key(op.f('fk_position_event_type_uuid_event_type'), 'position', 'event_type', ['event_type_uuid'], ['uuid']) | ||
| op.add_column('seatmap', sa.Column('event_type_uuid', sa.UUID(), nullable=True)) | ||
| op.create_foreign_key(op.f('fk_seatmap_event_type_uuid_event_type'), 'seatmap', 'event_type', ['event_type_uuid'], ['uuid']) | ||
| op.add_column('seatmap_background', sa.Column('event_type_uuid', sa.UUID(), nullable=True)) |
Contributor
There was a problem hiding this comment.
why is nullable true? are we planning to support shared seatmap backgrounds?
Member
Author
There was a problem hiding this comment.
I don't think so, but as everything else in this revision, we need to start with setting nullable to True, and insert an initial event brand uuid before we can set it to false?
| class EventType(Base): | ||
| __tablename__ = "event_type" | ||
|
|
||
| uuid = Column(UUID(as_uuid=True), primary_key=True, default=uuid.uuid4, unique=True, nullable=False) |
Contributor
There was a problem hiding this comment.
I think we agreed to use a string instead of uuid here, since people will need to know/remember it when configuring clients?
Contributor
There was a problem hiding this comment.
so like a slug instead of uuid? (which is a string which we enforce to be lowercase letters and -_ or something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.