forked from tortoise/tortoise-orm
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/allow pass configuration for to ts query #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fullonic
wants to merge
13
commits into
develop
Choose a base branch
from
feature/allow-pass-configuration-for-ToTsQuery
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−13
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
433084b
Add `PlainToTsQuery` postgres function
fullonic b7ab205
Allow pass a postgres function to SearchCriterion
fullonic 26b0924
Update docs
fullonic af3216a
Allow pass the config name for search functions
fullonic 185809e
`SearchCriterion` extracts config name from `expr`
fullonic b131dd3
Add `DEFAULT_TEXT_SEARCH_CONFIG`
fullonic 1336bf0
Get `config_name` `expr` args
fullonic 3edc1f9
Merge branch 'develop' into feature/allow-pass-dictonary-to-search
fullonic 01bf325
Remove old implementation of `PlainToTsQuery`
fullonic 347eacd
Merge branch 'develop' into feature/allow-pass-dictonary-to-search
fullonic 63e3378
Merge branch 'develop' into feature/allow-pass-configuration-for-ToTs…
fullonic 02a7f93
Merge branch 'develop' into feature/allow-pass-configuration-for-ToTs…
fullonic 52d6aaa
Fix lib version in pyproject
fullonic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accessing
expr.args[0].valueassumes the first argument is always a literal config name; this is brittle. Consider adding a dedicatedconfig_nameattribute or accessor on your Function subclasses to make this extraction safer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quizá tendría sentido validarlo antes de intentar desempaquetarlo
quizá también tendría sentido mejorar la readability manteniendo el orden original y la opcionalidad de la config