ci: add per-PR EN-Revision hash check#413
Open
lacatoire wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GitHub Actions workflow that runs on every pull request and verifies that the
EN-Revisionheader in modified XML files points to the latestdoc-encommit for that file.How it works
pull_requestevents targetingmaster.xmlfiles changed in the PRdoc-en, reads the declaredEN-Revisionhashgit log -1on the matchingdoc-enfile::errorannotation and fails if the hash is missing or outdatedThis ensures that translation updates always reference the exact upstream commit they are based on, making future sync work easier to track.
Prior art
This check is already in use in
doc-fr,doc-ru, anddoc-es. There is also an ongoing initiative indoc-baseto provide reusable workflows that alldoc-*repos can share.