Cleanup with performance gain#40
Draft
NickSdot wants to merge 15 commits into
Draft
Conversation
NickSdot
force-pushed
the
stack-09-performance
branch
from
July 22, 2026 05:40
6f758d4 to
bcd595a
Compare
NickSdot
force-pushed
the
stack-09-performance
branch
from
July 22, 2026 07:39
bcd595a to
20ffd41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
AbstractSniff::elementNameRanges()to centralises math and deduplicate. Plus shaves roughly 12% off sniffing and 10% off fixing. Before this, we materialised complete lines and source ranges for every candidate. Now we first only do line numbers; ranges are only created for candidates that will be promoted to actual violations.Depends on #29, #30, #31, #32, #33, #34, #35, #36, #37, #38 and #39.
This PRs diff will shrink as preceding PRs are merged and this branch is rebased.
Diff against previous branch: NickSdot:stack-08-cleanup...NickSdot:stack-09-performance (different to diff in here only until the previous branch was merged)
.... --wideSince this wasn't explained before: the 115,113 vs 45,171 difference comes from entity handling:
mainreports violations from entity expansion against every referencing file -> duplicates--wideadds those referenced source files as targets; hwoever it does not report duplicates likemain