Skip to content

Adds fixer outcomes to reporting#41

Draft
NickSdot wants to merge 19 commits into
php:mainfrom
NickSdot:stack-10-reporting
Draft

Adds fixer outcomes to reporting#41
NickSdot wants to merge 19 commits into
php:mainfrom
NickSdot:stack-10-reporting

Conversation

@NickSdot

Copy link
Copy Markdown
Contributor

Console, JSON, perf now report fixes; Checkstyle unchanged.

Depends on #29, #30, #31, #32, #33, #34, #35, #36, #37, #38, #39 and #40.
This PRs diff will shrink as preceding PRs are merged and this branch is rebased.

Diff against previous branch: NickSdot:stack-09-performance...NickSdot:stack-10-reporting (different to diff in here only until the previous branch was merged)

Console Output

OK -- 1 file(s) scanned, no violations remaining.
Total runtime: 2.000s

FIXING
----------------------------------------
  Files changed                            1
  Fixes applied                            2
  Fixes skipped                            0
  Fixing passes                            1

PERFORMANCE
----------------------------------------

Sniffing:
 DocbookCS.Simpara                         1.000s ( 50.0%)
 DocbookCS.ExceptionName                   0.250s ( 12.5%)

Fixing:
 Total                                     0.500s ( 25.0%)

Future Scope

While working on this I realised related architectural weakness. Pretty sure you will spot it either here or already in earlier branches. :) I, however, think changing it in here would make the PR explode in scope. For that reason I here focus on the actual report result/output instead of underlying architecture that would touch much of the processing related stuff. Will follow up for the rest in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant