Throw a ValueError when the parameter includes NUL bytes in strptime#21830
Closed
LamentXU123 wants to merge 1 commit intophp:masterfrom
Closed
Throw a ValueError when the parameter includes NUL bytes in strptime#21830LamentXU123 wants to merge 1 commit intophp:masterfrom
strptime#21830LamentXU123 wants to merge 1 commit intophp:masterfrom
Conversation
devnexen
reviewed
Apr 22, 2026
|
|
||
| ?> | ||
| --EXPECTF-- | ||
| Deprecated: Function strptime() is deprecated since 8.2, use date_parse_from_format() (for locale-independent parsing), or IntlDateFormatter::parse() (for locale-dependent parsing) instead in %s on line %d |
Member
There was a problem hiding this comment.
not sure it is worth it in that case because ^
Contributor
Author
There was a problem hiding this comment.
Yeah me too. Not sure if this should be done in deprecated functions
Member
|
I don't think it's worth to this in a function that has been deprecated for a while and will probably soon be removed anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resulted in:
Actually the ValueError-type changes can be done in bulk in the future. However,
strptimeis now deprecated so I don't sure if we should update this function as well. Feel free to close this if this shouldn't be done on deprecated functions