Split streams filter seekability into read and write fields#21878
Open
bukka wants to merge 1 commit intophp:masterfrom
Open
Split streams filter seekability into read and write fields#21878bukka wants to merge 1 commit intophp:masterfrom
bukka wants to merge 1 commit intophp:masterfrom
Conversation
bukka
force-pushed
the
stream_filter_write_seek
branch
from
eb7170f to
1545a13
Compare
The single seekable field caused write-chain seeks to reset filter state after the bug #49874 fix, breaking dechunk on php://temp (used by Symfony HttpClient). Split into read_seekable and write_seekable. Write defaults to ALWAYS for stateless and non-buffering filters. Buffer-holding filters (zlib, bz2, convert.*) accept a write_seek_mode parameter: "preserve" (default), "reset", or "strict". Invalid values throw ValueError. php_user_filter::seek gains a third int $chain argument; the ops seek signature is unchanged.
bukka
force-pushed
the
stream_filter_write_seek
branch
from
1545a13 to
7aba509
Compare
|
|
||
| /** @tentative-return-type */ | ||
| public function seek(int $offset, int $whence): bool {} | ||
| public function seek(int $offset, int $whence, int $chain): bool {} |
Contributor
There was a problem hiding this comment.
this has to be an optional arg to preserve BC
Contributor
There was a problem hiding this comment.
hum, maybe I'm wrong in the sense that this isn't enforced? then maybe we should have a test that shows user-filters with no $chain still work?
Member
Author
There was a problem hiding this comment.
This was introduced with that seek change and is present only in master so no BC break in any case... :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single seekable field caused write-chain seeks to reset filter state after the bug #49874 fix, breaking dechunk on php://temp (used by Symfony HttpClient).
Split into read_seekable and write_seekable. Write defaults to ALWAYS for stateless and non-buffering filters. Buffer-holding filters (zlib, bz2, convert.*) accept a write_seek_mode parameter: "preserve" (default), "reset", or "strict". Invalid values throw ValueError.
php_user_filter::seek gains a third int $chain argument; the ops seek signature is unchanged.