ext/odbc: Get the exact length for quoted connection string components#21892
Merged
NattyNarwhal merged 2 commits intophp:masterfrom Apr 29, 2026
Merged
ext/odbc: Get the exact length for quoted connection string components#21892NattyNarwhal merged 2 commits intophp:masterfrom
NattyNarwhal merged 2 commits intophp:masterfrom
Conversation
strlen has to scan the string until the end of the null terminator, we might as well do the same but scan for end quotes that need escaping.
SakiTakamachi
approved these changes
Apr 28, 2026
Member
SakiTakamachi
left a comment
SakiTakamachi
left a comment
There was a problem hiding this comment.
It makes sense to me :)
Girgias
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor optimization: strlen has to scan the string anyways. We might as well do it ourselves to look for the characters that need quoting instead of assuming the worst, and save a little bit of memory.