Skip to content

zend_types: Remove Z_*CONSTANT_*()#22295

Merged
TimWolla merged 2 commits into
php:masterfrom
TimWolla:remove-z-constant
Jul 6, 2026
Merged

zend_types: Remove Z_*CONSTANT_*()#22295
TimWolla merged 2 commits into
php:masterfrom
TimWolla:remove-z-constant

Conversation

@TimWolla

Copy link
Copy Markdown
Member

This macro is very rarely used and badly named by neither including the IS nor the AST in its name.

This macro is very rarely used and badly named by neither including the `IS`
nor the `AST` in its name.
@iluuu1994

Copy link
Copy Markdown
Member

For my zval experiment, these macros were actually pretty useful. E.g. we can use more optimized variants over Z_TYPE_P in some cases. I don't have strong opinions for this one.

@TimWolla
TimWolla merged commit e758d88 into php:master Jul 6, 2026
18 checks passed
@TimWolla
TimWolla deleted the remove-z-constant branch July 7, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants