Use zend_hash_find_ptr_lc() for case-insensitive name lookups#22591
Open
jorgsowa wants to merge 3 commits into
Open
Use zend_hash_find_ptr_lc() for case-insensitive name lookups#22591jorgsowa wants to merge 3 commits into
jorgsowa wants to merge 3 commits into
Conversation
Girgias
requested changes
Jul 6, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Except the reflection changes, makes sense.
jorgsowa
force-pushed
the
jorgsowa/hash-find-ptr-lc-batch2
branch
2 times, most recently
from
July 10, 2026 21:36
d4f63f7 to
3c9862b
Compare
Continues php#22565 for four sites that were missed: _class_exists_impl(), function_exists(), pdo_stmt.c's dbstmt_method_get(), ReflectionClass:: hasMethod()/getMethod(), and phpdbg's print func/method commands. No behavior change.
jorgsowa
force-pushed
the
jorgsowa/hash-find-ptr-lc-batch2
branch
from
July 18, 2026 21:31
3c9862b to
a774713
Compare
DanielEScherzer
requested changes
Jul 19, 2026
DanielEScherzer
left a comment
DanielEScherzer
left a comment
Member
There was a problem hiding this comment.
only reviewed ext/reflection
| { | ||
| reflection_object *intern; | ||
| zend_class_entry *ce; | ||
| zend_function *mptr; |
Member
There was a problem hiding this comment.
you have some unrelated changes, presumably from a rebase - please move/restore variables to be declared as late as possible
zend_function *mptrandzval obj_tmpshould be right beforeis_invokeis definedis_invokeshould be declared and defined in the same statement
Contributor
Author
There was a problem hiding this comment.
That's true. Thanks for catching it
DanielEScherzer
approved these changes
Jul 19, 2026
DanielEScherzer
left a comment
DanielEScherzer
left a comment
Member
There was a problem hiding this comment.
okay for ext/reflection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #22565 for four sites that were missed:
_class_exists_impl(),function_exists(),pdo_stmt.c'sdbstmt_method_get(),ReflectionClass:: hasMethod()/getMethod(), and phpdbg's print func/method commands. No behavior change.