ext/dom: Fix Dom\DtdNamedNodeMap index overflow in dimension access#22630
Merged
Conversation
devnexen
reviewed
Jul 7, 2026
| } | ||
| } | ||
|
|
||
| dump_access(fn() => $doc->doctype->entities[$overflow]); |
Member
There was a problem hiding this comment.
nit: let s test the negative values too
Member
Author
There was a problem hiding this comment.
Given other modern DOM collection dimension returns None in negative indexes and ValueError in out-of-range indexes, let's align with them.
$element->attributes[-1]; // NULL
$doctype->entities->item(4294967296); // ValueError: Argument #1 ($index) must be between 0 and 2147483647
devnexen
approved these changes
Jul 8, 2026
Member
Author
|
Does this need a UPGRADING entry? @devnexen |
Member
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dom\DtdNamedNodeMap dimension access could overflow the index when reading DTD entities or notations.