Skip to content

Use correct format string in curl debug messages #22723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimWolla merged 2 commits into from
Jul 14, 2026
Merged

Use correct format string in curl debug messages #22723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57d3888
Use correct format string in curl debug messages
Sjord Jul 14, 2026
f56f4c4
Print another pointer with %p instead of %x
Sjord Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ext/curl/interface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ static size_t curl_write(char *data, size_t size, size_t nmemb, void *ctx)

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_write() called\n");
fprintf(stderr, "data = %s, size = %d, nmemb = %d, ctx = %x\n", data, size, nmemb, ctx);
fprintf(stderr, "data = %s, size = %zu, nmemb = %zu, ctx = %p\n", data, size, nmemb, (void *) ctx);
Comment thread
TimWolla marked this conversation as resolved.
#endif

switch (write_handler->method) {
Expand Down Expand Up @@ -610,7 +610,7 @@ static int curl_progress(void *clientp, double dltotal, double dlnow, double ult

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_progress() called\n");
fprintf(stderr, "clientp = %x, dltotal = %f, dlnow = %f, ultotal = %f, ulnow = %f\n", clientp, dltotal, dlnow, ultotal, ulnow);
fprintf(stderr, "clientp = %p, dltotal = %f, dlnow = %f, ultotal = %f, ulnow = %f\n", clientp, dltotal, dlnow, ultotal, ulnow);
#endif
if (!ZEND_FCC_INITIALIZED(ch->handlers.progress)) {
return rval;
Expand Down Expand Up @@ -651,7 +651,7 @@ static int curl_xferinfo(void *clientp, curl_off_t dltotal, curl_off_t dlnow, cu

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_xferinfo() called\n");
fprintf(stderr, "clientp = %x, dltotal = %ld, dlnow = %ld, ultotal = %ld, ulnow = %ld\n", clientp, dltotal, dlnow, ultotal, ulnow);
fprintf(stderr, "clientp = %p, dltotal = %ld, dlnow = %ld, ultotal = %ld, ulnow = %ld\n", clientp, dltotal, dlnow, ultotal, ulnow);
#endif
if (!ZEND_FCC_INITIALIZED(ch->handlers.xferinfo)) {
return rval;
Expand Down Expand Up @@ -746,7 +746,7 @@ static int curl_ssh_hostkeyfunction(void *clientp, int keytype, const char *key,

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_ssh_hostkeyfunction() called\n");
fprintf(stderr, "clientp = %x, keytype = %d, key = %s, keylen = %zu\n", clientp, keytype, key, keylen);
fprintf(stderr, "clientp = %p, keytype = %d, key = %s, keylen = %zu\n", clientp, keytype, key, keylen);
#endif

zval args[4];
Expand Down Expand Up @@ -843,7 +843,7 @@ static int curl_seek(void *clientp, curl_off_t offset, int origin)

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_seek() called\n");
fprintf(stderr, "clientp = %x, offset = %ld, origin = %d\n", clientp, offset, origin);
fprintf(stderr, "clientp = %p, offset = %ld, origin = %d\n", clientp, offset, origin);
#endif
if (!ZEND_FCC_INITIALIZED(ch->handlers.seek)) {
return rval;
Expand Down Expand Up @@ -2801,7 +2801,7 @@ static void curl_free_obj(zend_object *object)
php_curl *ch = curl_from_obj(object);

#if PHP_CURL_DEBUG
fprintf(stderr, "DTOR CALLED, ch = %x\n", ch);
fprintf(stderr, "DTOR CALLED, ch = %p\n", (void *) ch);
Comment thread
TimWolla marked this conversation as resolved.
#endif

if (!ch->cp) {
Expand Down
Loading