ext/reflection: various cleanups and simplifications (3)#22795
Open
DanielEScherzer wants to merge 6 commits into
Open
ext/reflection: various cleanups and simplifications (3)#22795DanielEScherzer wants to merge 6 commits into
DanielEScherzer wants to merge 6 commits into
Conversation
Use `uint32_t` for values that are really `uint32_t`, like constant module numbers and the result from `zend_hash_num_elements()`. Use `uint32_t` for counting up, when values should never be negative. Adjust format specifiers to use `%u` rather than `%d` for the unsigned values.
Put the `*` next to the name, rather than the type
Avoid tabs or multiple spaces other than for indentation, remove a leading newline from `ReflectionProperty::hasHook()`
Girgias
approved these changes
Jul 18, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Minor nit regarding the printf style format strings, otherwise LGTM.
| /* The information where a class is declared is only available for user classes */ | ||
| if (ce->type == ZEND_USER_CLASS) { | ||
| smart_str_append_printf(str, "%s @@ %s %d-%d\n", indent, ZSTR_VAL(ce->info.user.filename), | ||
| smart_str_append_printf(str, "%s @@ %s %u-%u\n", indent, ZSTR_VAL(ce->info.user.filename), |
Member
There was a problem hiding this comment.
If it's a uint32_t the specifier should be %" PRIu32 "
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.