ext/gmp: Fix GMP error messages using outdated parameter names - #22846
Merged
Conversation
Girgias
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument name in these error messages are different from what is claimed in the documentation and public signatures.
gmp_root(GMP|int|string $num, int $nth): GMP
https://www.php.net/manual/en/function.gmp-root.php
gmp_rootrem(GMP|int|string $num, int $nth): array
https://www.php.net/manual/en/function.gmp-rootrem.php
gmp_random_range(GMP|int|string $min, GMP|int|string $max): GMP
https://www.php.net/manual/en/function.gmp-random-range.php
Updated messages:
TBH this is discovered when I am developing an application using gmp, and it take me some time to figure out what $a is in the error message.
Maybe we shouldn't hard code the argument name at first. IMO this is classic bad practice.