ext/intl: Refactor global error resets - #22990
Draft
LamentXU123 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the intl code base is using
intl_error_reset(NULL);in the start of every PHP_FUNCTION to reset the error state. I'd suggest to add something likeSo we can directly use the PHP_INTL_FUNCTION_WITH_ERROR_RESET macro to automatically reset error state in the start of every userland function.
I am working on this idea but this should be a massive refactor. Because I found so many cases that we forgot to reset error state in the start of php_functions that cause bugs. e.g.: #22931 #22500 and it is really annoying to add a line to reset the state in every function.
Some PHP_FUNCTION do the error state reset in internal helper function calls. Those are not affected.