Remove checkDataProviderData and introduce reportMissingDataProviderReturnType

[VincentLanglet]

Cf #246 (comment)

I did ignoreMissingDataProviderReturnType rather than reportMissingDataProviderReturnType because it allows to write

	PHPStan\Type\PHPUnit\DataProviderReturnTypeIgnoreExtension:
		phpstan.ignoreErrorExtension: [%featureToggles.bleedingEdge%, %phpunit.ignoreMissingDataProviderReturnType%]

and I dunno how a syntax

	PHPStan\Type\PHPUnit\DataProviderReturnTypeIgnoreExtension:
		phpstan.ignoreErrorExtension: [%featureToggles.bleedingEdge%, NOT(%phpunit.reportMissingDataProviderReturnType%)]

would exists

[ondrejmirtes]

"ignoreMissing" is a double negative. It requires a lot of mental gymnastics to figure out "do I need true or false for what I want?". That's why reportMissingDataProviderReturnType is a lot more natural.

AFAIK not(...) should work as expected: https://doc.nette.org/en/dependency-injection/services#toc-special-functions

If it doesn't we need to do some work in phpstan-src to enable that.

[VincentLanglet]

AFAIK not(...) should work as expected: doc.nette.org/en/dependency-injection/services#toc-special-functions

If it doesn't we need to do some work in phpstan-src to enable that.

I'm getting

Invalid configuration:
The item 'conditionalTags › PHPStan\Type\PHPUnit\DataProviderReturnTypeIgnoreExtension › phpstan.ignoreErrorExtension › 1' expects to be bool, object _PHPStan_f0675a7b6\Nette\DI\Definitions\Statement given.

with not(%phpunit.reportMissingDataProviderReturnType%)

or maybe am I doing it wrong ?

[ondrejmirtes]

Yeah, that's what I'm talking about, some amends need to be made in phpstan-src first.

[VincentLanglet]

Ok, so I'll try to introduce this syntax on phpstan-src (with phpstan/phpstan-src#4512)

[ondrejmirtes]

You can now take advantage of this here 😊

[VincentLanglet]

You can now take advantage of this here 😊

Nice, Ci is green

[VincentLanglet]

Friendly ping @ondrejmirtes I'd like to use this option :)

[ondrejmirtes]

Thank you!

[LastDragon-ru]

@ondrejmirtes , @VincentLanglet how to disable this rule??? I do not have a time (and the desire to be honest) to fix "Found 354 errors" now nor to add them into baseline :|

[ondrejmirtes]

@LastDragon-ru Do not use bleeding edge, or put them into the baseline.