Skip to content

Lazier return in UnionType->isSuperTypeOfWithReason() (~40% faster) #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 2 commits into from
Nov 30, 2024
Merged

Lazier return in UnionType->isSuperTypeOfWithReason() (~40% faster) #3692

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b104b4
Lazier return in `UnionType->isSuperTypeOfWithReason()`
staabm Nov 29, 2024
6b13264
simplify
staabm Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Type/UnionType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,16 @@ public function isSuperTypeOfWithReason(Type $otherType): IsSuperTypeOfResult
return $otherType->isSubTypeOfWithReason($this);
}

$result = IsSuperTypeOfResult::createNo()->or(...array_map(static fn (Type $innerType) => $innerType->isSuperTypeOfWithReason($otherType), $this->types));
$results = [];
foreach ($this->types as $innerType) {
$result = $innerType->isSuperTypeOfWithReason($otherType);
if ($result->yes()) {
return $result;
}
$results[] = $result;
Comment on lines +249 to +254
Copy link
Contributor Author

@staabm staabm Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic analog TrinaryLogic->lazyOr()

}

$result = IsSuperTypeOfResult::createNo()->or(...$results);
if ($result->yes()) {
Copy link
Member

@ondrejmirtes ondrejmirtes Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cannot be a yes after this, righr. It could be deleted.

Copy link
Contributor Author

@staabm staabm Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

return $result;
}
Expand Down
Loading