Fix ReflectionClassWithLazyObjects ReflectionClass stub #4606
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this stub should match: https://github.com/phpstan/phpstan-src/blob/2.1.x/stubs/ReflectionClass.stub#L4C13-L4C23 See this commit for where the lazy object was introduced: phpstan@25ec5eb#diff-34b8ba0664529e6e59d2c54a9a4cf3194fe2937582419c8d71516783474f4dc6 If you agree I think the same is needed for Enum.
Member
|
Separate Because when you do something like that, you get this error: It's explained here: https://phpstan.org/blog/whats-up-with-template-covariant If you want to see me talk about it, here's a video with a timestamp (https://youtu.be/eRvH9CP4YfY?si=ALy2sEKSqnSYLFbW&t=1818 - 30:18) |
Contributor
Author
|
I've asked a question about this here: phpstan/phpstan#13891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this stub should match: https://github.com/phpstan/phpstan-src/blob/2.1.x/stubs/ReflectionClass.stub#L4C13-L4C23
See this commit for where the lazy object was introduced: 25ec5eb#diff-34b8ba0664529e6e59d2c54a9a4cf3194fe2937582419c8d71516783474f4dc6
If you agree I think the same is needed for Enum. I can make a PR for that too.