Narrow CURLOPT_SHARE accepting type #4611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Dec 4, 2025
Comment on lines
1219
to
1220
| new ResourceType(), // PHP 7.x | ||
| new ObjectType('CurlShareHandle'), // since PHP 8.0 | ||
| new ObjectType('CurlSharePersistentHandle'), // since PHP 8.5 |
Contributor
Author
There was a problem hiding this comment.
we don't have access to PhpVersion at this point, therefore I hardcoded all possible types.
I think it doesn't really matter to narrow this further, because the values will be created by php-src builtin functions, so cannot be wrongly instantiated at runtime.
ondrejmirtes
requested changes
Dec 5, 2025
| return new UnionType([ | ||
| new ResourceType(), // PHP 7.x | ||
| new ObjectType('CurlShareHandle'), // since PHP 8.0 | ||
| new ObjectType('CurlSharePersistentHandle'), // since PHP 8.5 |
Member
There was a problem hiding this comment.
You can ask PhpVersionStaticAccessor.
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since PHP8.5 there is also
CurlSharePersistentHandlecreated via curl_share_init_persistent