Skip to content

Check bench/data files with RequiredPhpVersionCommentTest - #6122

Merged
staabm merged 3 commits into
phpstan:2.2.xfrom
staabm:bench-lint
Jul 28, 2026
Merged

Check bench/data files with RequiredPhpVersionCommentTest#6122
staabm merged 3 commits into
phpstan:2.2.xfrom
staabm:bench-lint

Conversation

@staabm

@staabm staabm commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

cleanup to support #6121


Fixes

There were 10 failures:

1) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/bug-14869-enum.php" ('/Users/m.staab/dvl/phpstan-sr...um.php')
Fixture uses enums on line 16 which requires PHP 8.1. Add a `<?php // lint >= 8.1` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80100 or is greater than 80100.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

2) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/impure-call-columns.php" ('/Users/m.staab/dvl/phpstan-sr...ns.php')
Fixture uses the mixed type on line 8 which requires PHP 8.0. Add a `<?php // lint >= 8.0` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80000 or is greater than 80000.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

3) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/union-fast-path.php" ('/Users/m.staab/dvl/phpstan-sr...th.php')
Fixture uses the mixed type on line 14 which requires PHP 8.0. Add a `<?php // lint >= 8.0` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80000 or is greater than 80000.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

4) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/wordpress-user.php" ('/Users/m.staab/dvl/phpstan-sr...er.php')
Fixture uses the mixed type on line 14 which requires PHP 8.0. Add a `<?php // lint >= 8.0` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80000 or is greater than 80000.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

5) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/bug-14319.php" ('/Users/m.staab/dvl/phpstan-sr...19.php')
Fixture uses union types on line 5 which requires PHP 8.0. Add a `<?php // lint >= 8.0` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80000 or is greater than 80000.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

6) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/bug-10979.php" ('/Users/m.staab/dvl/phpstan-sr...79.php')
Fixture uses enums on line 7 which requires PHP 8.1. Add a `<?php // lint >= 8.1` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80100 or is greater than 80100.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

7) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/bug-11283.php" ('/Users/m.staab/dvl/phpstan-sr...83.php')
Fixture uses the mixed type on line 119 which requires PHP 8.0. Add a `<?php // lint >= 8.0` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80000 or is greater than 80000.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

8) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/bug-10772.php" ('/Users/m.staab/dvl/phpstan-sr...72.php')
Fixture uses enums on line 21 which requires PHP 8.1. Add a `<?php // lint >= 8.1` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80100 or is greater than 80100.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

9) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/bug-12159.php" ('/Users/m.staab/dvl/phpstan-sr...59.php')
Fixture uses typed class constants on line 29 which requires PHP 8.3. Add a `<?php // lint >= 8.3` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80300 or is greater than 80300.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

10) PHPStan\Build\RequiredPhpVersionCommentTest::testFixtureHasRequiredLintComment with data set "/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/../../bench/data/bug-13352.php" ('/Users/m.staab/dvl/phpstan-sr...52.php')
Fixture uses the mixed type on line 32 which requires PHP 8.0. Add a `<?php // lint >= 8.0` comment on the first line so the fixture is skipped on older PHP versions in CI.
Failed asserting that 0 is equal to 80000 or is greater than 80000.

/Users/m.staab/dvl/phpstan-src/tests/PHPStan/Build/RequiredPhpVersionCommentTest.php:102

FAILURES!
Tests: 17558, Assertions: 89823, Failures: 10, Skipped: 188.
make: *** [tests] Error 1

@staabm
staabm marked this pull request as ready for review July 28, 2026 10:03
@phpstan-bot

Copy link
Copy Markdown
Collaborator

This pull request has been marked as ready for review.

@staabm staabm changed the title Check bench files with RequiredPhpVersionCommentTest Check bench/data files with RequiredPhpVersionCommentTest Jul 28, 2026
@staabm
staabm requested review from VincentLanglet, Copilot and ondrejmirtes and removed request for Copilot July 28, 2026 10:25
@staabm
staabm merged commit 18ea956 into phpstan:2.2.x Jul 28, 2026
741 of 745 checks passed
@staabm
staabm deleted the bench-lint branch July 28, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants