Track containsNullsafe on ExpressionResult and propagate it through fetch/call chains - #6143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from the
resolve-type-rewrite-2branch (independent PR on 2.2.x) — one of the non-callbackExpressionResultconstructor arguments the eventual switch builds on.A boolean flag on
ExpressionResultrecording whether the expression's chain contains a nullsafe operator, propagated through the fetch/call handlers (a fetch/call on a receiver whose chain short-circuits propagates null, which a plain nullable receiver does not — this flag is what tells them apart). Inert plumbing on 2.2.x for now — the branch's nullsafe short-circuit decisions consume it — landed with the branch's exact field ordering so the sweep diff shrinks; the one factory caller passing scope callbacks positionally switches to named arguments.Validation: full test suite green (17778 tests), self-analysis clean, code style clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_019wqGgaD7iqL44t1KgpJS7b