Update dependency rules_python to v1.8.4

[phst]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @phst, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request upgrades the rules_python dependency to version 1.8.4 and integrates a set of custom patches to address specific issues and ensure proper functionality within the Bazel build system. This update improves the stability and correctness of Python runfiles handling and other related aspects, ensuring better compatibility and reliability for Python-based projects.

Highlights

• Dependency Update: The rules_python dependency was updated from v1.7.0 to v1.8.4.
• Custom Patch Application: A single_version_override was introduced in MODULE.bazel to apply a custom patch file (rules_python.patch) to the rules_python module.
• Copyright Year Update: The copyright year in MODULE.bazel was extended to 2026.
• Lock File Synchronization: The MODULE.bazel.lock file was updated to reflect the new rules_python version and its associated content hashes.
• New Patch File: A new file, rules_python.patch, was added containing several fixes for rules_python, including runfiles path correction, a new data file test, a zip file bootstrap workaround, a changelog update, and mypy type adjustments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• MODULE.bazel
  • Updated the rules_python dependency version from 1.7.0 to 1.8.4.
  • Added a single_version_override to apply rules_python.patch to the rules_python module.
  • Extended the copyright year from 2025 to 2026.
• MODULE.bazel.lock
  • Modified the locked hashes and URLs for rules_python to reflect version 1.8.4.
  • Removed the source.json hash for the previous 1.7.0 version.
• rules_python.patch
  • Introduced a new file containing five distinct patches for rules_python.
  • Included a fix for Python runfiles path assumptions.
  • Added a test for data file location.
  • Provided a workaround for buggy zip file bootstrap.
  • Updated the changelog within the patched module.
  • Made adjustments to appease mypy type hinting.

Activity

• The pull request was opened by phst to update the rules_python dependency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the rules_python dependency to version 1.8.4 and applies a series of patches via single_version_override. While updating dependencies is a good practice, the first patch in the rules_python.patch file appears to be incorrect. It contradicts its own commit message and the accepted fix in the upstream repository for the issue it claims to address. This could re-introduce a bug related to runfiles path resolution. This is a critical issue that needs to be addressed before merging.