Skip to content

Conversation

@bishoy-at-pieces
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 12, 2026 17:58
vendor.txt Outdated
Comment on lines 5 to 6
pydantic==2.12.5
pydantic_core==2.41.5

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades pydantic from version 1.10.15 to 2.12.5, which is a major version upgrade with breaking changes. The upgrade also adds pydantic_core as a new dependency, which is required for pydantic v2, and updates the typing-extensions version.

Changes:

  • Upgraded pydantic from 1.10.15 to 2.12.5 (major version bump)
  • Added pydantic_core==2.41.5 as a new dependency
  • Updated typing-extensions from an implicit version to 4.14.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vendor.txt Outdated
Comment on lines 5 to 9
pydantic==2.12.5
pydantic_core==2.41.5
python-dateutil==2.9.0.post0
typing-extensions==4.14.0
websocket-client==1.8.0
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pydantic v2 introduced major breaking changes that are incompatible with the existing pydantic.patch file. The patch file at tools/vendoring/patches/pydantic.patch references v1-specific modules and APIs like pydantic.color, pydantic.types, and the _hypothesis_plugin.py structure, which have been significantly restructured in v2. This patch needs to be updated to work with pydantic v2 before upgrading, otherwise the vendoring process will fail or produce broken imports.

Suggested change
pydantic==2.12.5
pydantic_core==2.41.5
python-dateutil==2.9.0.post0
typing-extensions==4.14.0
websocket-client==1.8.0
pydantic==1.10.19
python-dateutil==2.9.0.post0
typing-extensions==4.14.0
websocket-client==1.8.0

Copilot uses AI. Check for mistakes.
@bishoy-at-pieces bishoy-at-pieces force-pushed the bishoy-at-pieces-patch-2 branch from a5ee70a to 2c75ba1 Compare January 12, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants