Support passing diff options to React components#416
Support passing diff options to React components#416amadeus merged 3 commits intopierrecomputer:mainfrom
Conversation
|
@gsabran is attempting to deploy a commit to the Pierre Computer Company Team on Vercel. A member of the Team first needs to authorize it. |
amadeus
left a comment
amadeus
left a comment
There was a problem hiding this comment.
Sorry for the delays on this, it's been a busy last couple weeks for me.
A couple small nits/questions/feedback, but pretty close I think
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
looks like there will be some conflicts to sort out as well |
packages/diffs/src/types.ts
Outdated
| * Options forwarded to the underlying diff algorithm when computing diffs | ||
| * from file contents (oldFile/newFile). Has no effect on pre-parsed patches. | ||
| */ | ||
| diffOptions?: ParseDiffOptions; |
There was a problem hiding this comment.
Sorry my bad, i meant the name of this option, not the type. parseDiffOptions: CreatePatchOptionsNonabortable
There was a problem hiding this comment.
I can also just merge this and do the rename myself too if you're tied up
There was a problem hiding this comment.
sry I didn't mean to push yet
There was a problem hiding this comment.
no worries, imo PR is good to go now, is there more you need to do on it?
…sNonabortable type
Address PR review feedback:
- Rename diffOptions → parseDiffOptions to align with parseDiffFromFile
- Expose full CreatePatchOptionsNonabortable instead of a two-field subset
- Remove unnecessary ?? {} coercion in areOptionsEqual
- Pass parseDiffOptions through in FileDiff base class calls
gsabran
force-pushed
the
whitespace-changes
branch
from
38ef1a2 to
b1568e1
Compare
amadeus
left a comment
amadeus
left a comment
There was a problem hiding this comment.
Sick! Thanks for bearing with me on this! 🙏
2 participants
Description
Support passing diff options to React components
Motivation & Context
I wanted a way to ignore whitespace only changes
Type of changes
first discussed with the dev team and they should be aware that this PR is
being opened
You must have first discussed with the dev team and they should be aware
that this PR is being opened
Checklist
contributing guidelines
bun run lint)bun run format)bun run diffs:test)How was AI used in generating this PR
I directed Claude to make the changes, reviewed and tested them carefully manually