Linter and link fixes, allow handling of "abort error"#35
Conversation
|
Hello, ty for this initiative, I really appreciate. I planned to do a lot of changes soon like you did, because several enhancement about go, tools and linters exists since I start to impl this library. And many idea to enhance this lib to do in my head. I'm ok to merge your contributions asap to restart the machine on this project. Please let me know when it will be not a draft. Have a good day :) |
|
I re-run |
pilebones
force-pushed
the
master
branch
3 times, most recently
from
5c1ec37 to
c3fe89d
Compare
|
Yes, I will be happy to! |
hut8
force-pushed
the
liam/linter-and-link-fixes
branch
from
0b44c10 to
01072ba
Compare
|
Rebased: let me know what you think 😄 |
| // see: | ||
| // - http://elixir.free-electrons.com/linux/v3.12/source/include/uapi/linux/netlink.h#L23 | ||
| // - http://elixir.free-electrons.com/linux/v3.12/source/include/uapi/linux/socket.h#L11 | ||
| // - https://elixir.bootlin.com/linux/v6.14.1/source/include/uapi/linux/netlink.h#L23 |
There was a problem hiding this comment.
Nice catch for these kind of changes, the site changed since I started this project 👍
But it is this link : https://elixir.bootlin.com/linux/v6.14.1/source/include/uapi/linux/netlink.h#L24
Btw, It could be nice to change also the links in the README.
| // - http://elixir.free-electrons.com/linux/v3.12/source/include/uapi/linux/netlink.h#L23 | ||
| // - http://elixir.free-electrons.com/linux/v3.12/source/include/uapi/linux/socket.h#L11 | ||
| // - https://elixir.bootlin.com/linux/v6.14.1/source/include/uapi/linux/netlink.h#L23 | ||
| // - https://elixir.bootlin.com/linux/v6.14.1/source/include/uapi/linux/socket.h#L11 |
There was a problem hiding this comment.
Wrong line in the link, this one is better :
https://elixir.bootlin.com/linux/v6.14.1/source/include/uapi/linux/socket.h#L10
2 participants
This is a group of a couple of fixes:
return errors.New("abort signal receive")was present in the middle of a function during the crawling of/sys/devices. That makes it so that we can't distinguish between that particular error and any other error (at least, not easily). That error is special because it's one that's actually triggered by the user just to stop the crawling process, so the user is very likely to treat it as not an error. This makes that possible.ioutilhas been deprecated for a long time now, so I replaced that withio.*oros.*.