Refactor adapter rendering: rename to DetailView pattern and expose SDK exports#1044
Merged
markus-moser merged 4 commits into2.xfrom Feb 19, 2026
Merged
Conversation
…DK exports - Rename AdapterFormProps to DataHubAdapterDetailViewProps with onDelete prop - Rename getFormComponent to renderDetailView on DynamicTypeDataHubAdapterAbstract - Replace BaseAdapterForm/useAdapterForm with BaseDetailView/useDetailView - Replace graphql-adapter-form.tsx with graphql-detail-view.tsx - Move base component folder from base-adapter-form/ to base-detail-view/ - Refactor ConfigTabContent/ConfigTabs: remove inline fetch, pass onDelete callback - Add adapterTypeLabel prop to GeneralTab for reuse across adapter types - Expose GeneralTab, PermissionsTab, service IDs, dynamic types, and BaseDetailView via sdk/index.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames all
*AdapterFormcomponents, hooks and types to the*DetailViewnaming convention, restructures thebase-detail-viewfolder, and exposes public SDK exports for use by third-party bundles.