Fix GraphQL element date resolver type error#1045
Open
umizoomi wants to merge 2 commits intopimcore:2.xfrom
Open
Fix GraphQL element date resolver type error#1045umizoomi wants to merge 2 commits intopimcore:2.xfrom
umizoomi wants to merge 2 commits intopimcore:2.xfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Root Cause
The
resolveModificationDate()andresolveCreationDate()methods were added in DataHub v2.x with strictarraytype hints, but they don't account forElementDescriptorobjects that are returned when resolving relation fields.Affected Queries
Related Files