Open
Conversation
- Extract collectServicesByType() helper method in ConfigurationDefinitionPass to eliminate 8 duplicated foreach loops - Add validateSchemaAwareSettings() helper method in ConfigurationValidationService to reduce duplication across validation methods - Fix line length issue in ConfigurationDefinitionPass (split long line) - Reduces cognitive complexity and improves maintainability
Add @phpstan-ignore-next-line comments for children() method calls that fail type inference with Symfony 6.4.0 (lowest dependencies). The children() method returns NodeParentInterface in older versions instead of NodeBuilder, causing PHPStan to complain about undefined methods like scalarNode(), enumNode(), etc.
Move @phpstan-ignore-next-line comments to the correct lines where the actual failing method calls occur (scalarNode, variableNode, arrayNode, enumNode) instead of on the children() line. PHPStan complains about these method calls, not about children() itself.
# Conflicts: # src/DataSource/Loader/HttpLoader.php
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the extensibility, validation, and AI integration capabilities of the Data Importer bundle. The changes include enhanced documentation for custom strategy development, new developer tools for configuration validation and schema introspection, experimental support for AI agent integration via MCP, and updates to example configurations. Additionally, interfaces for schema awareness and validation are now implemented in core cleanup strategies, and minor dependency and code quality improvements are made.
Extensibility and Developer Tools
SchemaAwareInterface,DataTargetFieldValidatorInterface, andTransformationTypeAwareInterfaceto enable automatic validation, schema introspection, and AI agent support.README.mdto include links to new extension documentation.Validation and Schema Awareness
SchemaAwareInterfacein core cleanup strategies (DeleteStrategy,UnpublishStrategy) to provide schema descriptions and enable validation tooling. [1] [2] [3]Example Configurations
Dependency and Codebase Improvements
composer.jsonto add dependencies for MCP SDK and HTTP message bridge, and to restrict plugin discovery forphp-http/discovery. [1] [2]phpstan-bootstrap.php. [1] [2]