Open
Conversation
Avamander
reviewed
Dec 27, 2020
|
These changes look good, thanks! Do you mind squashing the commits together? I'm generally in favor of as granular commits as possible, but one commit per line change seems a little excessive :) (I can also just merge with squash if you prefer that, but you won't have control over the final commit message if I do it that way.) |
Author
|
Yes could you please merge with squash for me thanks! I haven't done squashing before and I'll probably mess it up 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the warnings in BL602 HAL generated by
xpack-riscv-none-embed-gcc 8.3.0-2.3when building for Mynewt OS. The warnings were due to buffer overflow, mismatched types, missing declarations and variables set but not used.