Add childrenForSemantics to delegate#47
Open
Albert221 wants to merge 3 commits intopingbird:masterfrom
Open
Conversation
Albert221
force-pushed
the
feat/children-for-semantics
branch
from
23430a7 to
d680e87
Compare
Albert221
force-pushed
the
feat/children-for-semantics
branch
from
d680e87 to
eaba5d1
Compare
Contributor
Author
|
@pingbird ping 👀 |
Owner
|
Apologies for the slow review, I have been out of the country since Christmas, will take a look in the next week |
Contributor
Author
|
@pingbird hey, have you had a chance to look at it yet? 👀 |
Contributor
Author
|
@pingbird bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45 -
visitChildrenForSemanticsnow respects delegate's children order.Added an overridable
childrenForSemanticsgetter toBaseBoxyDelegatethat controls the order children are visited for semantics. By default, it returnschildrenin paint order while filtering out ignored children. This means delegates that overridechildren(e.g., for custom paint/hit-test order) will now automatically have their semantics follow the same order.Delegates can also override
childrenForSemanticsdirectly for independent control over semantics traversal when needed.Also added a new
BoxyDelegatePhase.semanticsphase to enable delegate access during semantics traversal, and included unit tests for the new functionality.