Skip to content

Fix Dumpling capitalization: product name should be capitalized#23042

Open
yahonda wants to merge 3 commits into
pingcap:release-8.5from
yahonda:topic/fix-dumpling-capitalization-release-8.5
Open

Fix Dumpling capitalization: product name should be capitalized#23042
yahonda wants to merge 3 commits into
pingcap:release-8.5from
yahonda:topic/fix-dumpling-capitalization-release-8.5

Conversation

@yahonda

@yahonda yahonda commented Jun 11, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Changed lowercase 'dumpling' to 'Dumpling' when it refers to the product name (TiDB data export tool) rather than the command line. This prevents mistranslation of the product name as a common noun (e.g., '餃子' or '団子' in Japanese) during localization.

Command line references (e.g., tiup dumpling) remain unchanged.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request capitalizes "dumpling" to "Dumpling" across several documentation files to ensure consistent terminology. The reviewer suggested additional improvements to align with the style guide, such as avoiding passive voice, correcting "TiDB-Lightning" to "TiDB Lightning", and simplifying phrasing to make instructions more direct.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread dm/dm-faq.md Outdated
Comment thread get-started-with-tidb-lightning.md Outdated
@yahonda yahonda force-pushed the topic/fix-dumpling-capitalization-release-8.5 branch from 3cdfb27 to a9dafee Compare June 11, 2026 07:50
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread dm/dm-faq.md Outdated
@qiancai qiancai self-assigned this Jun 12, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 12, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-12 05:54:06.574935801 +0000 UTC m=+1112147.645253211: ☑️ agreed by qiancai.

@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-master Should cherry pick this PR to master branch. labels Jun 12, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jun 12, 2026
github-actions Bot added a commit to qiancai/docs-cn that referenced this pull request Jun 12, 2026
Synced from: pingcap/docs#23042
Target PR: pingcap#21713
AI Provider: azure

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants