Skip to content

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jan 13, 2026

This PR fixes a few playground configuration issues for CSE/NextGen modes.

  • Record the bound component version on playground instances when binpath != ""
  • Add missing CSE TiDB options (columnar store type, fulltext index, TiFlash addresses)
  • Allow NextGen system TiDB to use multiple tikv-worker endpoints

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from breezewish and kaaaaaaang January 13, 2026 08:30
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 31.25000% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.53%. Comparing base (0890ea9) to head (e0a9aa0).

Files with missing lines Patch % Lines
components/playground/instance/tidb_config.go 0.00% 11 Missing ⚠️
components/playground-ng/proc/tidb_config.go 0.00% 7 Missing ⚠️
components/playground-ng/service/tidb.go 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2666   +/-   ##
=======================================
  Coverage   41.52%   41.53%           
=======================================
  Files         417      417           
  Lines       45579    45595   +16     
=======================================
+ Hits        18926    18934    +8     
- Misses      24109    24115    +6     
- Partials     2544     2546    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@breezewish
Copy link
Member

breezewish commented Jan 13, 2026

We now have a https://github.com/pingcap/tiup/tree/master/components/playground-ng could you try to fix over it as well? :)

- Record bound component version for playground instances
- Add missing CSE options (columnar store type, fulltext index, TiFlash addresses)
- Allow NextGen system TiDB to point to multiple tikv-worker endpoints
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2026
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 13, 2026
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 14, 2026
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 15, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-13 14:22:03.411634189 +0000 UTC m=+367367.473499094: ☑️ agreed by breezewish.
  • 2026-01-14 07:12:29.225101464 +0000 UTC m=+427993.286966373: ✖️🔁 reset by Lloyd-Pottiger.
  • 2026-01-15 16:19:56.759600526 +0000 UTC m=+78824.373557372: ☑️ agreed by breezewish.

@Lloyd-Pottiger
Copy link
Contributor Author

/cc @xhebox

@ti-chi-bot ti-chi-bot bot requested a review from xhebox January 20, 2026 05:56
@xhebox xhebox merged commit 7d025cb into pingcap:master Jan 20, 2026
17 of 27 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-issues branch January 20, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants