-
Notifications
You must be signed in to change notification settings - Fork 330
playground: fix config in CSE/NextGen modes #2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2666 +/- ##
=======================================
Coverage 41.52% 41.53%
=======================================
Files 417 417
Lines 45579 45595 +16
=======================================
+ Hits 18926 18934 +8
- Misses 24109 24115 +6
- Partials 2544 2546 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We now have a https://github.com/pingcap/tiup/tree/master/components/playground-ng could you try to fix over it as well? :) |
- Record bound component version for playground instances - Add missing CSE options (columnar store type, fulltext index, TiFlash addresses) - Allow NextGen system TiDB to point to multiple tikv-worker endpoints
0b7c815 to
afacad6
Compare
[LGTM Timeline notifier]Timeline:
|
|
/cc @xhebox |
This PR fixes a few playground configuration issues for CSE/NextGen modes.
binpath != ""