Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Infer Copilot reasoning support from runtime models - Remove the explicit "Use model default" option - Update picker and registry tests for the new default
…rendering and ensure test co-ex
| }); | ||
| } | ||
|
|
||
| const existing = sessions.get(input.threadId); |
There was a problem hiding this comment.
🟢 Low Layers/CopilotAdapter.ts:1390
When startSession finds an existing session with the same threadId, it returns the existing session immediately without applying any of the input parameters (model, reasoningEffort, runtimeMode). If the caller intends to reconfigure the session, those parameters are silently ignored and the existing session's current configuration is returned instead. Consider either reconfiguring the session to match the new parameters or throwing an error when the requested configuration differs from the existing session.
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file apps/server/src/provider/Layers/CopilotAdapter.ts around line 1390:
When `startSession` finds an existing session with the same `threadId`, it returns the existing session immediately without applying any of the input parameters (`model`, `reasoningEffort`, `runtimeMode`). If the caller intends to reconfigure the session, those parameters are silently ignored and the existing session's current configuration is returned instead. Consider either reconfiguring the session to match the new parameters or throwing an error when the requested configuration differs from the existing session.
Evidence trail:
apps/server/src/provider/Layers/CopilotAdapter.ts lines 1380-1403 (REVIEWED_COMMIT): Shows `startSession` returning existing session with `existing.runtimeMode`, `existing.model` instead of input parameters when `sessions.get(input.threadId)` finds a match.
apps/server/src/provider/Layers/CopilotAdapter.ts lines 1430-1483 (REVIEWED_COMMIT): Shows new session creation properly using `input.model`, `input.runtimeMode`, and `reasoningEffort` from input - confirming the contrast with the existing session path.
…copilot-integration # Conflicts: # apps/web/src/routes/_chat.settings.tsx
…and empty strings
…agesTimeline components
What Changed
Why
UI Changes
Checklist
Note
Add GitHub Copilot as a supported AI provider
CopilotAdapterservice in CopilotAdapter.ts that integrates@github/copilot-sdk, supporting session start/resume, turn sending/aborting, interactive permission prompts, user-input requests, model/reasoning-effort switching, and thread reading.claude-sonnet-4.6), reasoning effort options, and persisted settings forcopilotCliPathandcopilotConfigDir.PROVIDER_OPTIONSentry labeled 'GitHub Copilot'.@github/copilot-sdk@0.1.32to fix an ESM import path indist/session.js.📊 Macroscope summarized 0a91001. 33 files reviewed, 8 issues evaluated, 1 issue filtered, 4 comments posted
🗂️ Filtered Issues
apps/web/src/appSettings.test.ts — 0 comments posted, 1 evaluated, 1 filtered
claude-sonnet-4.6(with a period) for the copilot provider, but the analogous claudeAgent test on line 227 expectsclaude-sonnet-4-6(with a hyphen). This inconsistency suggests a copy-paste typo - either the model slug format is wrong (period vs hyphen), or the copilot test should be checking for a copilot-specific normalized slug rather than a claude model slug. [ Out of scope (triage) ]