fix(server): pass mcpServers and plugins to Claude Agent SDK#1336
Closed
AssahBismarkabah wants to merge 2 commits intopingdotgg:mainfrom
Closed
fix(server): pass mcpServers and plugins to Claude Agent SDK#1336AssahBismarkabah wants to merge 2 commits intopingdotgg:mainfrom
AssahBismarkabah wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
Got it @juliusmarminge Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The Claude adapter now forwards
mcpServersandpluginsfrom provider options to the SDK'squery()call. Previously these were missing fromqueryOptions, so every Claude Agent session started with emptymcp_serversandpluginsregardless of what the caller passed in.Changes:
ClaudeProviderStartOptionswith optionalmcpServersandpluginsfields (packages/contracts/src/orchestration.ts)queryOptionswhen present(
apps/server/src/provider/Layers/ClaudeAdapter.ts)(
apps/server/src/provider/Layers/ClaudeAdapter.test.ts)Follows the same pattern as the existing
binaryPath,permissionMode, andmaxThinkingTokenspassthrough.Why
Fixes #1271
The SDK supports
mcpServersandpluginsin itsOptionstype butmakeClaudeAdapternever wires them through. This means MCP tools are completely unavailable when using the Claude Agent provider, even if the caller includes them inproviderOptions.Note: this unblocks MCP support on the adapter side. The web UI does not currently populate these fields that can be addressed separately once the team decides how MCP configuration should surface (settings UI, filesystem loading via
settingSources, etc.).Checklist
Note
Pass
mcpServersandpluginsfrom provider options to Claude Agent SDK query optionsmcpServersandplugins, to theClaudeProviderStartOptionsschema in orchestration.ts.startSessionhandler in ClaudeAdapter.ts now conditionally forwards these fields into the query options when present.Macroscope summarized 0677433.