-
Notifications
You must be signed in to change notification settings - Fork 2.2k
apps/web: add in-thread find/search for chat conversations #1501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leonardoxr
wants to merge
12
commits into
pingdotgg:main
Choose a base branch
from
leonardoxr:feat/thread-search-1486
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6851efc
Add in-thread search for chat conversations
leonardoxr 3bc2ef0
Address thread search review feedback
leonardoxr e25b5c2
Address follow-up thread search review feedback
leonardoxr e7882f7
Align thread search with rendered content
leonardoxr e806f7b
Align thread search with rendered markdown text
leonardoxr 93e93b4
Fix thread search indexing edge cases
leonardoxr 633d906
Fix thread search rebase fallout
leonardoxr efbd61f
Address thread search review feedback
leonardoxr 8ac1cc5
Fix thread search review edge cases
leonardoxr 3347f86
Align thread search labels with rendered chips
leonardoxr 0db8951
Fix timeline search rendering updates
leonardoxr 896b034
Fix thread search highlight rendering edge cases
leonardoxr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| import { renderToStaticMarkup } from "react-dom/server"; | ||
| import { describe, expect, it, vi } from "vitest"; | ||
|
|
||
| vi.mock("../hooks/useTheme", () => ({ | ||
| useTheme: () => ({ | ||
| theme: "light", | ||
| resolvedTheme: "light", | ||
| }), | ||
| })); | ||
|
|
||
| describe("ChatMarkdown", () => { | ||
| it("highlights assistant markdown text matches", async () => { | ||
| const { default: ChatMarkdown } = await import("./ChatMarkdown"); | ||
| const markup = renderToStaticMarkup( | ||
| <ChatMarkdown | ||
| text="The **highlight** should appear inside assistant markdown." | ||
| cwd={undefined} | ||
| searchQuery="highlight" | ||
| searchActive | ||
| />, | ||
| ); | ||
|
|
||
| expect(markup).toContain('data-thread-search-highlight="active"'); | ||
| expect(markup).toContain("<mark"); | ||
| expect(markup).toContain(">highlight<"); | ||
| }); | ||
|
|
||
| it("highlights fenced code matches without dropping the visible mark", async () => { | ||
| const { default: ChatMarkdown } = await import("./ChatMarkdown"); | ||
| const markup = renderToStaticMarkup( | ||
| <ChatMarkdown | ||
| text={"```ts\nconst highlightNeedle = true;\n```"} | ||
| cwd={undefined} | ||
| searchQuery="highlightNeedle" | ||
| searchActive | ||
| />, | ||
| ); | ||
|
|
||
| expect(markup).toContain('data-thread-search-highlight="active"'); | ||
| expect(markup).toContain("<mark"); | ||
| expect(markup).toContain(">highlightNeedle<"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.